Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 )
Change subject: IMPALA-5031: Fix undefined behavior: memset NULL ...................................................................... Patch Set 2: > Do we want to update the other call sites of std::memset? Not yet. First, when I last submitted a patch with many memset fixes some months ago,it had trouble getting through review. Second, not every call needs to be fixed, since some don't call it with a NULL parameter and so do not induce undefined behavior. > IMPALA-5031 is quite general, while this patch set is very > specific. Is IMPALA-5031 some kind of umbrella Jira for all the > ubsan-related issues? Yes. -- To view, visit http://gerrit.cloudera.org:8080/10948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Gerrit-Change-Number: 10948 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 17 Jul 2018 13:02:56 +0000 Gerrit-HasComments: No
