Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10948 )
Change subject: IMPALA-5031: Fix undefined behavior: memset NULL ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/10948/3/be/src/util/ubsan.h File be/src/util/ubsan.h: http://gerrit.cloudera.org:8080/#/c/10948/3/be/src/util/ubsan.h@26 PS3, Line 26: class Ubsan { bikeshedding opportunity here: when I saw the name 'ubsan.h' and the name of this class, I thought this would have various utility code to deal with interfacing with ubsan itself (eg util/asan.h has macros for interfacing with ASAN) In fact this is more like a "safe memory utilities" class. Consider a different name? -- To view, visit http://gerrit.cloudera.org:8080/10948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18fa02dc887a42a94c6f81e4923d17568f2184f2 Gerrit-Change-Number: 10948 Gerrit-PatchSet: 3 Gerrit-Owner: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 17 Jul 2018 18:44:04 +0000 Gerrit-HasComments: Yes
