Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10972 )
Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10972/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10972/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2160 PS1, Line 2160: */ > should this method be removed in favor of the one in the catalog util? ah, yes... I think I went back and forth on which place to put this static method and somehow ended up with both. Do you prefer here or FeCatalogUtil? The advantage of here is that it makes the patch show fewer changed lines vs moving it. -- To view, visit http://gerrit.cloudera.org:8080/10972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7baf05f16c6389ed900e0459708005ab44491e Gerrit-Change-Number: 10972 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 19 Jul 2018 02:08:37 +0000 Gerrit-HasComments: Yes
