Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10972 )
Change subject: IMPALA-7307 (part 2). Support TABLESAMPLE in LocalCatalog ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10972/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10972/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2160 PS1, Line 2160: */ > I'm fine with the move to utils. its consistent with the other changes and k, deleted this copy. I'm going to put up a new commit at some time soon to try to consolidate these util functions into a more consistent pattern but didn't make the changes here to avoid churning the patch too much. -- To view, visit http://gerrit.cloudera.org:8080/10972 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f7baf05f16c6389ed900e0459708005ab44491e Gerrit-Change-Number: 10972 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Jul 2018 23:10:46 +0000 Gerrit-HasComments: Yes
