Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10982 )
Change subject: IMPALA-7219. 7.5% of Catalog Server heap wasted by empty HashMaps and ArrayLists ...................................................................... Patch Set 2: (2 comments) thx for the changes! questions: (1) do you know which one of these contributes to more empty collections (structs or tables) for the case(s) you looked at? (2) an empty collection for a struct comes up when it has no fields (otherwise there will be no savings). have you seen examples of call-sites where these data structures are created with no fields? perhaps some of those are worth following up (separately). http://gerrit.cloudera.org:8080/#/c/10982/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10982/2//COMMIT_MSG@14 PS2, Line 14: pls add any tests that you ran. for this change, passing existing tests should be fine. http://gerrit.cloudera.org:8080/#/c/10982/2/fe/src/main/java/org/apache/impala/catalog/Table.java File fe/src/main/java/org/apache/impala/catalog/Table.java: http://gerrit.cloudera.org:8080/#/c/10982/2/fe/src/main/java/org/apache/impala/catalog/Table.java@320 PS2, Line 320: { : return; : } nit: single line -- To view, visit http://gerrit.cloudera.org:8080/10982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9c75f65ecb3ba3f2c739fa483a84dc052f471c6 Gerrit-Change-Number: 10982 Gerrit-PatchSet: 2 Gerrit-Owner: Misha Dmitriev <count...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Jul 2018 17:55:58 +0000 Gerrit-HasComments: Yes
