Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10982 )
Change subject: IMPALA-7219. 7.5% of Catalog Server heap wasted by empty HashMaps and ArrayLists ...................................................................... Patch Set 2: Yep, that makes sense -- lazy initializing the StructType field in Table looks like an easy win here. You're right that changing the treatment of IncompleteTable would be a much deeper change. Worth adding to the commit message, btw, that the "7.5% of catalog server heap" is in the case where the catalog is mostly made up of IncompleteTables. Or quantify the number of bytes per IncompleteTable that are saved. That way we can pretty easily estimate the absolute heap size savings on an arbitrary catalog just by knowing how many tables they have. -- To view, visit http://gerrit.cloudera.org:8080/10982 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9c75f65ecb3ba3f2c739fa483a84dc052f471c6 Gerrit-Change-Number: 10982 Gerrit-PatchSet: 2 Gerrit-Owner: Misha Dmitriev <count...@gmail.com> Gerrit-Reviewer: Misha Dmitriev <count...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Jul 2018 20:36:58 +0000 Gerrit-HasComments: No
