Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11002 )
Change subject: IMPALA-3675: part 1: -Werror for ASAN ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/11002/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11002/4//COMMIT_MSG@9 PS4, Line 9: This fixes some clang warnings and enables -Werror going forward for > I don't see any diffs, other than the mismatched struct/class ones. I feel The clang-tidy precommit prevented most warnings from cropping up. The only fixes were from enabling the matched tags check and to suppress return-type-c-linkage that is also suppressed in clang-tidy. http://gerrit.cloudera.org:8080/#/c/11002/4/be/CMakeLists.txt File be/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/11002/4/be/CMakeLists.txt@105 PS4, Line 105: # Enabled for DEBUG and ASAN builds which are built pre-commit. > TSAN and UBSAN, too, or do you think that's overzealous? Will do that. I don't expect any issues but will rerun the build job to check: https://jenkins.impala.io/job/all-build-options-ub1604/2165 -- To view, visit http://gerrit.cloudera.org:8080/11002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec Gerrit-Change-Number: 11002 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Jul 2018 22:51:42 +0000 Gerrit-HasComments: Yes
