Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11002 )
Change subject: IMPALA-3675: part 1: -Werror for ASAN ...................................................................... IMPALA-3675: part 1: -Werror for ASAN This fixes some clang warnings and enables -Werror going forward for ASAN. It adds -Wno-return-type-c-linkage to suppress a warning that otherwise would fail the build. It also enables the mismatched tags check and fixes the various instances of it (this warning is irritating for YouCompleteMe users). Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec Reviewed-on: http://gerrit.cloudera.org:8080/11002 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M .clang-tidy M be/CMakeLists.txt M be/src/exec/hdfs-table-writer.h M be/src/exprs/expr.h M be/src/exprs/scalar-expr.h M be/src/runtime/krpc-data-stream-recvr.h M be/src/runtime/mem-tracker.h 7 files changed, 10 insertions(+), 13 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/11002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec Gerrit-Change-Number: 11002 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
