Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10998 )
Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility ...................................................................... Patch Set 3: (2 comments) didn't review the code in detail, just one high-level suggestion here http://gerrit.cloudera.org:8080/#/c/10998/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10998/3//COMMIT_MSG@42 PS3, Line 42: These metrics are exposed on the daemon's web UI in /memz page under : section "JVM Garbage Collection metrics". They can also be consumed : by tools from the /metrics endpoint. Are these redundant with the metrics that are available in the JMX MBean? If we expose JMXJsonServlet (or its moral equivalent piped through our C++ webserver) then we'll fit in with the standard of the other Hadoop daemons for exposing the JVM stats. See http://namenode:5070/jmx (eg using the namenode in your minicluster) to see what I mean. The metrics in there are a lot more granular, including info like the heap size after the last collection (a decent estimate of live heap), etc. If possible, it might be nice to include in these metrics some other info that's _not_ available above, eg a histogram of GC times or pause times. Also, would be good to expose the host machine pause time which may not be GC-related. (eg timestamp of last N pauses, length of last pauses) http://gerrit.cloudera.org:8080/#/c/10998/3/common/thrift/Frontend.thrift File common/thrift/Frontend.thrift: http://gerrit.cloudera.org:8080/#/c/10998/3/common/thrift/Frontend.thrift@830 PS3, Line 830: 3: required i64 collection_time if you don't take my other suggestion about exposing "/jmx" directly, it would be good to expose the info from "memoryUsageBeforeGc" and "memoryUsageAfterGc" elements in JMX,as well as the timestamp and duration of the most recent GC. -- To view, visit http://gerrit.cloudera.org:8080/10998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d897b7e063846ad6d8f88243e2c04264da0341 Gerrit-Change-Number: 10998 Gerrit-PatchSet: 3 Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Thu, 26 Jul 2018 16:09:56 +0000 Gerrit-HasComments: Yes
