Bharath Vissapragada has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10998 )

Change subject: IMPALA-6857: Add Jvm pause/GC Monitor utility
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10998/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/10998/3//COMMIT_MSG@42
PS3, Line 42: These metrics are exposed on the daemon's web UI in /memz page 
under
            : section "JVM Garbage Collection metrics". They can also be 
consumed
            : by tools from the /metrics endpoint.
> Are these redundant with the metrics that are available in the JMX MBean? I
Yea, these are the same as JMX MBean.

I thought about it for a while and settled with this because the JVM memory 
metrics was implemented this way [1](I'm not sure why). Looking at the jmx 
output, it is way more detailed and can be consumed by a variety of tools. 
Lemme try doing that and see how it works. Will get back.

[1] 
https://github.com/apache/impala/commit/daf0626dbd4171dc582160af467cf1638271dc60



--
To view, visit http://gerrit.cloudera.org:8080/10998
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I30d897b7e063846ad6d8f88243e2c04264da0341
Gerrit-Change-Number: 10998
Gerrit-PatchSet: 3
Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Thu, 26 Jul 2018 18:08:01 +0000
Gerrit-HasComments: Yes

Reply via email to