Le Minh Nghia has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@614 PS5, Line 614: self.leading_comment = leading_comment > nit: . at the end Done http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@616 PS5, Line 616: return self.default(line) : return func(arg) : > How about moving this to a new set_prompt(db) function? Done http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@862 PS5, Line 862: If immediately is True, it executes the USE command right away. > It is a matter of taste, but I would change this to Done http://gerrit.cloudera.org:8080/#/c/10992/5/shell/impala_shell.py@863 PS5, Line 863: """ > nit: . at the end Done http://gerrit.cloudera.org:8080/#/c/10992/5/tests/custom_cluster/test_shell_interactive_reconnect.py File tests/custom_cluster/test_shell_interactive_reconnect.py: http://gerrit.cloudera.org:8080/#/c/10992/5/tests/custom_cluster/test_shell_interactive_reconnect.py@89 PS5, Line 89: impalad = ImpaladService(socket.getfqdn()) > I would prefer to kill/restart only the impalad that the shell has connecte Done http://gerrit.cloudera.org:8080/#/c/10992/5/tests/custom_cluster/test_shell_interactive_reconnect.py@91 PS5, Line 91: > Can we use ImpalaShell.DISCONNECTED_PROMPT here instead of the hard-coded s Done -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 6 Gerrit-Owner: Le Minh Nghia <le.ng...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Le Minh Nghia <le.ng...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 30 Jul 2018 17:11:07 +0000 Gerrit-HasComments: Yes
