Le Minh Nghia has posted comments on this change. ( http://gerrit.cloudera.org:8080/10992 )
Change subject: IMPALA-6490: Reconnect shell when remote restarts ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/10992/7/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/10992/7/shell/impala_shell.py@859 PS7, Line 859: return > nit: I think you'll need to write it in the next line because PEP8 won't li Done http://gerrit.cloudera.org:8080/#/c/10992/7/tests/common/custom_cluster_test_suite.py File tests/common/custom_cluster_test_suite.py: http://gerrit.cloudera.org:8080/#/c/10992/7/tests/common/custom_cluster_test_suite.py@159 PS7, Line 159: if "--kill" in options: : return > I think it is not needed anymore because this method is only used for start Done -- To view, visit http://gerrit.cloudera.org:8080/10992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia13365a9696886f01294e98054cf4e7cd66ab712 Gerrit-Change-Number: 10992 Gerrit-PatchSet: 7 Gerrit-Owner: Le Minh Nghia <le.ng...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Le Minh Nghia <le.ng...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Jul 2018 16:44:31 +0000 Gerrit-HasComments: Yes
