Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 )
Change subject: IMPALA-7317: loosen flake8 rules ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg File setup.cfg: http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg@23 PS1, Line 23: ignore = E111,E114,E121,E128,E701 I'm getting issues with E125 also with code like this: def long_function_name_so_i_need_to_wrap_params( long, parameter, list): pass It raises "E125 continuation line with same indent as next logical line" on the wrapped parameter list, because it sees it as +4 indentation (one indentation level) from the definition, and expects that the body of the function will also be +4. But, since we use +2 indent level in general, the complaint actually doesn't make sense. Perhaps we should disable E125 or figure out some way to hack flake8 to understand the +2 base indentation? -- To view, visit http://gerrit.cloudera.org:8080/11102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997 Gerrit-Change-Number: 11102 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 21:30:40 +0000 Gerrit-HasComments: Yes
