Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11102 )
Change subject: IMPALA-7317: loosen flake8 rules ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg File setup.cfg: http://gerrit.cloudera.org:8080/#/c/11102/1/setup.cfg@23 PS1, Line 23: ignore = E111,E114,E121,E128,E701 > The correct formatting for the above is this: I'm not sure the "wrong" example is really wrong, at least according to flake8. With 4-space whitespace, it is fine with this: def test_incompatible_avro_partition_in_non_avro_table( self, vector, unique_database, main_table_format): pass (in fact, autopep8 corrects it to that). However, if I replace the 4-indentation with 2-indentation above, I get: /tmp/test.py:2:5: E125 continuation line with same indent as next logical line self, vector, unique_database, main_table_format): ^ /tmp/test.py:3:3: E111 indentation is not a multiple of four pass ^ So, in our case, we've silenced E111, but then the confusion over indentation makes it falsely trigger E125, no? -- To view, visit http://gerrit.cloudera.org:8080/11102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997 Gerrit-Change-Number: 11102 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 01 Aug 2018 22:14:36 +0000 Gerrit-HasComments: Yes
