Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11102 )
Change subject: IMPALA-7317: loosen flake8 rules ...................................................................... IMPALA-7317: loosen flake8 rules I got feedback that the flake8 rules are a little too strict, so based on the d...@impala.apache.org discussion am disabling some of them. I left E302 "expected 2 blank lines, found 1" enabled since I think it would force our formatting to be more consistent, but I'm open to changing that. I used the following command to get a sense of the number of existing violations: EXCLUDES=ext-py,shell/build,gerrit_critic_venv,infra/python/env EXCLUDES+=,shell/pkg_resources.py,shell/thrift_sasl.py,gen-py EXCLUDES+=,TPC-DS-master,toolchain ./bin/impala-flake8 --exclude=${EXCLUDES} Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997 Reviewed-on: http://gerrit.cloudera.org:8080/11102 Reviewed-by: Tim Armstrong <tarmstr...@cloudera.com> Tested-by: Tim Armstrong <tarmstr...@cloudera.com> --- M bin/jenkins/critique-gerrit-review.py M setup.cfg 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Tim Armstrong: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/11102 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iaaa8377025e732231ac0f1f1f2db67298a171997 Gerrit-Change-Number: 11102 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>