Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11124 )
Change subject: IMPALA-7364: Bump RapidJSON version to 1.1.0 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/rpc/impala-service-pool.cc File be/src/rpc/impala-service-pool.cc: http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/rpc/impala-service-pool.cc@268 PS2, Line 268: value->AddMember("idle_threads", Value(service_queue_.estimated_idle_worker_count()).Move(), line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/util/metrics.h File be/src/util/metrics.h: http://gerrit.cloudera.org:8080/#/c/11124/2/be/src/util/metrics.h@169 PS2, Line 169: document->AddMember(rapidjson::StringRef(key_.c_str()), val, document->GetAllocator()); line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11124 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21353b0d769f81c13f506737e41fbac17655245c Gerrit-Change-Number: 11124 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sat, 04 Aug 2018 14:50:53 +0000 Gerrit-HasComments: Yes
