Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/11075 )
Change subject: IMPALA-4690: [DOCS] More content for CONV() ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@279 PS2, Line 279: eph>cosh(double a)</codeph> : </dt> > Whether a number or a string, the return values are the same. I changed it Would you add an example with a number, too? http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml@235 PS3, Line 235: <codeph>-1</codeph>, <codeph>0</codeph>, or <codeph>1</codeph>. </li> > How are negative bases interpreted when `a` is a negative number? How about This comment was missed, I think. http://gerrit.cloudera.org:8080/#/c/11075/4/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11075/4/docs/topics/impala_math_functions.xml@224 PS4, Line 224: 62 64, right? -- To view, visit http://gerrit.cloudera.org:8080/11075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e424fd5a009ff5aa2d35a403e08fcd33c75fec5 Gerrit-Change-Number: 11075 Gerrit-PatchSet: 4 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Mon, 06 Aug 2018 16:26:52 +0000 Gerrit-HasComments: Yes
