Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/11075 )
Change subject: IMPALA-4690: [DOCS] More content for CONV() ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11075/2/docs/topics/impala_math_functions.xml@279 PS2, Line 279: eph>cosh(double a)</codeph> : </dt> > Would you add an example with a number, too? Done http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11075/3/docs/topics/impala_math_functions.xml@235 PS3, Line 235: and <codeph>from_base</codeph> is a negative number.</li> > This comment was missed, I think. Returns 0 - added http://gerrit.cloudera.org:8080/#/c/11075/4/docs/topics/impala_math_functions.xml File docs/topics/impala_math_functions.xml: http://gerrit.cloudera.org:8080/#/c/11075/4/docs/topics/impala_math_functions.xml@224 PS4, Line 224: ph > 64, right? Done -- To view, visit http://gerrit.cloudera.org:8080/11075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4e424fd5a009ff5aa2d35a403e08fcd33c75fec5 Gerrit-Change-Number: 11075 Gerrit-PatchSet: 3 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Comment-Date: Mon, 06 Aug 2018 18:17:41 +0000 Gerrit-HasComments: Yes
