Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11232 )
Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object wrappers for FileDescriptor ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11232/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java: http://gerrit.cloudera.org:8080/#/c/11232/1/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@636 PS1, Line 636: encodedFileDescriptors_.isEmpty() > indeed that's bizarre... let me see if I can understand what's going on her appears it's always non-null. I added an annotation and removed the null check in getNumFileDescriptors. -- To view, visit http://gerrit.cloudera.org:8080/11232 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I986dd5c05ac8904898d01a6ef3487bd7225e0500 Gerrit-Change-Number: 11232 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 15 Aug 2018 19:05:13 +0000 Gerrit-HasComments: Yes
