Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11232 )

Change subject: IMPALA-7406. Avoid memory overhead of FlatBuffer object 
wrappers for FileDescriptor
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/11232/2/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java
File fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java:

http://gerrit.cloudera.org:8080/#/c/11232/2/fe/src/main/java/org/apache/impala/catalog/HdfsPartition.java@745
PS2, Line 745: ImmutableList.copyOf(
> Do we still need this?
nope, good point.



--
To view, visit http://gerrit.cloudera.org:8080/11232
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I986dd5c05ac8904898d01a6ef3487bd7225e0500
Gerrit-Change-Number: 11232
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Aug 2018 18:38:02 +0000
Gerrit-HasComments: Yes

Reply via email to