Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 )
Change subject: IMPALA-7433: reduce logging on executors ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-exec-mgr.cc File be/src/runtime/query-exec-mgr.cc: http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-exec-mgr.cc@155 PS3, Line 155: VLOG(2) This may be useful for debugging issue such as IMPALA-7194. Not sure if the newly added line below is sufficient as it may help to see when each fragment instance finishes. http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/11202/3/be/src/runtime/query-state.cc@356 PS3, Line 356: VLOG(2) This one may be useful to keep to indicate whether we manage to get to the point of starting fragment instances after creating the QueryState. While we may consider bumping the log level when problem occurs, this may be a bit hard in practice if the problem is due to a race which doesn't occur consistently. -- To view, visit http://gerrit.cloudera.org:8080/11202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c1db44acc6def2b05a4fd032c63716e08cdf5ff Gerrit-Change-Number: 11202 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Aug 2018 20:18:10 +0000 Gerrit-HasComments: Yes
