Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 )
Change subject: IMPALA-7433: reduce logging on executors ...................................................................... Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11202/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11202/4//COMMIT_MSG@19 PS4, Line 19: I0813 12:10:50.374167 31259 query-state.cc:485] Instance completed. instance_id=fd4ae28bc993236e:27343be100000003 #in-flight=1 status=OK At this point the interesting question is often "Which one is the last instance that's missing?". Can we print the instance IDs of the last 3 remaining instances? Or a random, running one every time an instance finishes? http://gerrit.cloudera.org:8080/#/c/11202/4/be/src/service/impala-internal-service.cc File be/src/service/impala-internal-service.cc: http://gerrit.cloudera.org:8080/#/c/11202/4/be/src/service/impala-internal-service.cc@49 PS4, Line 49: VLOG_QUERY << "ExecQueryFInstances():" << " query_id=" Porting this RPC to KRPC (IMPALA-7467) will put a queue between the incoming RPC and the actual fragment instance startup. It might make sense to log both events, but if we only opt for one, then the actual dequeue and startup might be more interesting. It's probably not something to decide now though. -- To view, visit http://gerrit.cloudera.org:8080/11202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c1db44acc6def2b05a4fd032c63716e08cdf5ff Gerrit-Change-Number: 11202 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Aug 2018 16:19:26 +0000 Gerrit-HasComments: Yes
