Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11208 )
Change subject: IMPALA-7437. LRU caching of partitions in impalad ...................................................................... Patch Set 6: (6 comments) oops, I forgot to publish these comments. I see there are more comments I need to address, but posting these older replies for now. http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@268 PS5, Line 268: le, colNam > yea, I actually ended up implementing the negative cache in a later patch i moved the "negative caching" into this patch. The trace message now reports positive hit, negative hit, and missing (total adds up to all of the columns) http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@289 PS5, Line 289: ats > with req, resp, and ret all looking fairly similar, perhaps call this one " Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@423 PS5, Line 423: > nit: inconsistent spacing. I'm just going with file consistency-- I've comp Apparently no space is more common in the codebase. I'll make this file consistent. (env)todd@va1022:/data/1/todd/impala$ git grep 'for.*(.* : .*)' fe | wc -l 220 (env)todd@va1022:/data/1/todd/impala$ git grep 'for.*(.*[^ ]: .*)' fe | wc -l 1060 http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@567 PS5, Line 567: } > nit: add a "TableMetaRef: " to make it easier to know that we're looking at Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@596 PS5, Line 596: */ > nit: add a newline Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java File fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java: http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/LocalFsTable.java@376 PS5, Line 376: should > nit: should Done -- To view, visit http://gerrit.cloudera.org:8080/11208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a57521ad851da605604a1e7c48d3d6627da5df5 Gerrit-Change-Number: 11208 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Aug 2018 01:45:56 +0000 Gerrit-HasComments: Yes