Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/11208 )
Change subject: IMPALA-7437. LRU caching of partitions in impalad ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java File fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java: http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@280 PS5, Line 280: // Fetch and re-add those missing ones. > perhaps add a comment here about this being the miss handler. Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/main/java/org/apache/impala/catalog/local/CatalogdMetaProvider.java@660 PS5, Line 660: * > nit: add newline to be consistent with other classes. Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java File fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java: http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@69 PS5, Line 69: > perhaps add the suffix "ByRefs" so its clearer that this test is aimed at t Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@71 PS5, Line 71: public void testCachePartitionList() throws Exception { > clearer to call this partialRefs Done http://gerrit.cloudera.org:8080/#/c/11208/5/fe/src/test/java/org/apache/impala/catalog/local/CatalogdMetaProviderTest.java@95 PS5, Line 95: Map<String, PartitionMetadata> partMap = provider_.loadPartitionsByRefs( > add a test for loadTableColumnStatistics did this in r6 -- To view, visit http://gerrit.cloudera.org:8080/11208 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9a57521ad851da605604a1e7c48d3d6627da5df5 Gerrit-Change-Number: 11208 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Aug 2018 01:57:18 +0000 Gerrit-HasComments: Yes
