Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 )
Change subject: IMPALA-7433: reduce logging on executors ...................................................................... Patch Set 4: (1 comment) I think there are good ideas but I was hoping to keep this change limited to modifying log messages rather than collecting new information to log. http://gerrit.cloudera.org:8080/#/c/11202/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11202/4//COMMIT_MSG@19 PS4, Line 19: I0813 12:10:50.374167 31259 query-state.cc:485] Instance completed. instance_id=fd4ae28bc993236e:27343be100000003 #in-flight=1 status=OK > At this point the interesting question is often "Which one is the last inst Can't we infer this from an "Executing instance" log without a corresponding "Instance completed" log. It might be useful to occasionally log the set of executing fragments plus additional info for long-running queries, e.g. in the ReportExecStatus() thread. That would probably be more useful than logging it opportunistically when a different fragment finishes. -- To view, visit http://gerrit.cloudera.org:8080/11202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c1db44acc6def2b05a4fd032c63716e08cdf5ff Gerrit-Change-Number: 11202 Gerrit-PatchSet: 4 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Aug 2018 21:58:13 +0000 Gerrit-HasComments: Yes
