Vincent Tran has posted comments on this change. ( http://gerrit.cloudera.org:8080/11293 )
Change subject: IMPALA-6758: Add metric for current catalog version to catalog ...................................................................... Patch Set 3: (1 comment) > (1 comment) > > I'm curious: what's the motivation for exposing this as a metric? > Why would the operator want to monitor it? The original motivation stemmed from IMPALA-6075 where I user had to investigate a metadata inconsistency issue. I think it makes sense to expose the metric in all three main daemons to be used via monitoring tools / infrastructure in this scenario. http://gerrit.cloudera.org:8080/#/c/11293/3/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/11293/3/be/src/catalog/catalog-server.cc@185 PS3, Line 185: current_catalog_version_metric_ = catalog_metrics->AddGauge : (CATALOG_CURRENT_TOPIC_VERSION > can you clarify which version this is? Confusingly there are two versions f Yes. I see the ambiguity. This should be the current catalog version set by the catalog. I think my earlier concern was that the existing metric catalog.version - which stores the version string of the Catalog Server - can cause some confusion if this new metric was named catalog-server.current-catalog-version. -- To view, visit http://gerrit.cloudera.org:8080/11293 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328 Gerrit-Change-Number: 11293 Gerrit-PatchSet: 3 Gerrit-Owner: Vincent Tran <vtt...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com> Gerrit-Comment-Date: Mon, 27 Aug 2018 12:47:34 +0000 Gerrit-HasComments: Yes
