Vincent Tran has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11293 )

Change subject: IMPALA-6758: Add metric for current catalog version to catalog
......................................................................


Patch Set 3:

I checked commit 572af614d6d2af21dc4d261a3c53ed9b2b05c833 for some precedence 
and it looks like the distinction between the version set by the catalog and 
the version that statestore operates on is made by appending the "Catalog" or 
"Statestore" in front of "topic version", i.e.:

"Catalog topic update version" and "Statestore topic update version" 
respectively.

For the sake of consistency, we can follow this same naming pattern without any 
objection.


--
To view, visit http://gerrit.cloudera.org:8080/11293
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff7e158292ca9e5a17663e5bfc74931cc57c0328
Gerrit-Change-Number: 11293
Gerrit-PatchSet: 3
Gerrit-Owner: Vincent Tran <vtt...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Pranay Singh
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Vincent Tran <vtt...@cloudera.com>
Gerrit-Comment-Date: Mon, 27 Aug 2018 15:32:03 +0000
Gerrit-HasComments: No

Reply via email to