Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11339 )
Change subject: IMPALA-7464: fix race when ExecFInstance() RPC times out ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h File be/src/runtime/query-state.h: http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@161 PS2, Line 161: ReleaseExecResourceRefcount() ReleaseBackendResourceRefcount() http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.h@186 PS2, Line 186: void AcquireBackendResourceRefcount(); Should we add a remark that this should not be called from coordinator and cite this JIRA as a problem ? -- To view, visit http://gerrit.cloudera.org:8080/11339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If60d983e0e68b00e6557185db1f86757ab8b3f2d Gerrit-Change-Number: 11339 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Aug 2018 01:09:43 +0000 Gerrit-HasComments: Yes
