Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11339 )
Change subject: IMPALA-7464: fix race when ExecFInstance() RPC times out ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11339/2//COMMIT_MSG@21 PS2, Line 21: (verified via code inspection) > I'd appreciate the code reviewer to verify this as well. Did some manual verification to ensure all resources released in QueryState::ReleaseExecResources() are only referenced by backend executors except for query_mem_tracker_ which is a control structure. http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.cc File be/src/runtime/query-state.cc: http://gerrit.cloudera.org:8080/#/c/11339/2/be/src/runtime/query-state.cc@93 PS2, Line 93: set_query_exec_finished(); This is apparently beyond the scope of this change: Does it make sense for some code in MemTracker to DCHECK / CHECK against this value to make sure query_mem_tracker_ is not used after this flag is set ? -- To view, visit http://gerrit.cloudera.org:8080/11339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If60d983e0e68b00e6557185db1f86757ab8b3f2d Gerrit-Change-Number: 11339 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 29 Aug 2018 01:20:34 +0000 Gerrit-HasComments: Yes
