Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 )
Change subject: WIP: IMPALA-6568 add missing Query Compilation section to profiles. ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1081 PS2, Line 1081: TQueryExecRequest queryExecRequest = getPlannedExecRequest(queryCtx, analysisResult, timeline, explainString); line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1130 PS2, Line 1130: private void setMtDopForCatalogOp(AnalysisResult analysisResult, TQueryOptions queryOptions) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1145 PS2, Line 1145: private TExecRequest createTExecRequest(TQueryCtx queryCtx, AnalysisResult analysisResult) { line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1157 PS2, Line 1157: private void addFinalizationParamsForInsert(TQueryCtx queryCtx, AnalysisResult analysisResult, line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1195 PS2, Line 1195: private TQueryExecRequest getPlannedExecRequest(TQueryCtx queryCtx, AnalysisResult analysisResult, line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/11387/2/fe/src/main/java/org/apache/impala/service/Frontend.java@1197 PS2, Line 1197: StringBuilder explainString) throws ImpalaException { line too long (103 > 90) -- To view, visit http://gerrit.cloudera.org:8080/11387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I869eaeb4be4291b6b938f91847f624c76ec90ea5 Gerrit-Change-Number: 11387 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 05 Sep 2018 20:12:41 +0000 Gerrit-HasComments: Yes
