Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11387 )
Change subject: IMPALA-6568 add missing Query Compilation section to profiles. ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/11387/3/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/11387/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1065 PS3, Line 1065: if (!analysisResult.isCreateTableAsSelectStmt()) { : return result; : } > I personally think it's weird, but the impala style is to use single-line i I tried this but I don't like it. I think its more readable how it is. I don't want to get into a code style war for my first (or second) change... so I will change this if you think it is best, but this doesn't look inconsistent with existing code. http://gerrit.cloudera.org:8080/#/c/11387/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1134 PS3, Line 1134: private void setMtDopForCatalogOp(AnalysisResult analysisResult, > can be static? same with several of the extracted functions below Done http://gerrit.cloudera.org:8080/#/c/11387/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1150 PS3, Line 1150: createTExecRequest > maybe rename this to 'createBaseExecRequest' or something? Otherwise it's s Done http://gerrit.cloudera.org:8080/#/c/11387/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1164 PS3, Line 1164: AnalysisResult analysisResult, > it seems this is just used to get the insertStmt, and the insertStmt is alr Done http://gerrit.cloudera.org:8080/#/c/11387/3/fe/src/main/java/org/apache/impala/service/Frontend.java@1185 PS3, Line 1185: void addQueryMetadata > it seems that 'result' is only used as an argument here for storing the fin Done -- To view, visit http://gerrit.cloudera.org:8080/11387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I869eaeb4be4291b6b938f91847f624c76ec90ea5 Gerrit-Change-Number: 11387 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 07 Sep 2018 18:45:40 +0000 Gerrit-HasComments: Yes
