Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 17: (42 comments) http://gerrit.cloudera.org:8080/#/c/10744/17/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10744/17/be/src/service/impala-server.cc@214 PS17, Line 214: DEFINE_int64(shutdown_grace_period_s, 120, "Shutdown startup grace period in seconds. When " line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/10744/17/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10744/17/common/thrift/ImpalaInternalService.thrift@842 PS17, Line 842: // Deadline for the shutdown. After this deadline expires (starting at the time when this line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_cluster.py@210 PS17, Line 210: : flake8: E701 multiple statements on one line (colon) http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_service.py File tests/common/impala_service.py: http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_service.py@178 PS17, Line 178: i flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_service.py@178 PS17, Line 178: i flake8: E125 continuation line with same indent as next logical line http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_service.py@210 PS17, Line 210: i flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_service.py@210 PS17, Line 210: i flake8: E125 continuation line with same indent as next logical line http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_service.py@216 PS17, Line 216: i flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@95 PS17, Line 95: r flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@101 PS17, Line 101: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@102 PS17, Line 102: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@106 PS17, Line 106: h flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@116 PS17, Line 116: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@126 PS17, Line 126: q flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@126 PS17, Line 126: : flake8: E231 missing whitespace after ':' http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@132 PS17, Line 132: q flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@138 PS17, Line 138: q flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@143 PS17, Line 143: " flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@144 PS17, Line 144: q flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@144 PS17, Line 144: : flake8: E231 missing whitespace after ':' http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@159 PS17, Line 159: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@160 PS17, Line 160: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@161 PS17, Line 161: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@166 PS17, Line 166: d flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@188 PS17, Line 188: = flake8: E712 comparison to True should be 'if cond is True:' or 'if cond:' http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@192 PS17, Line 192: t flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@193 PS17, Line 193: i flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@252 PS17, Line 252: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@253 PS17, Line 253: = flake8: E225 missing whitespace around operator http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@254 PS17, Line 254: @ flake8: E301 expected 1 blank line, found 0 http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@260 PS17, Line 260: g flake8: E126 continuation line over-indented for hanging indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@262 PS17, Line 262: F flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@289 PS17, Line 289: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@290 PS17, Line 290: flake8: E203 whitespace before ':' http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@294 PS17, Line 294: S flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@295 PS17, Line 295: d flake8: E306 expected 1 blank line before a nested definition, found 0 http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@297 PS17, Line 297: S flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@318 PS17, Line 318: T flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@327 PS17, Line 327: s flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@337 PS17, Line 337: s flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@344 PS17, Line 344: s flake8: E128 continuation line under-indented for visual indent http://gerrit.cloudera.org:8080/#/c/10744/17/tests/custom_cluster/test_restart_services.py@345 PS17, Line 345: r flake8: F841 local variable 'result' is assigned to but never used -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 10 Sep 2018 17:57:26 +0000 Gerrit-HasComments: Yes
