Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10744 )
Change subject: IMPALA-1760: Implement shutdown command ...................................................................... Patch Set 18: (8 comments) http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.h@108 PS18, Line 108: /// 2. The startup grace period starts, during which: > Can this be based instead on a successful startup indicator/flag that gets The grace period is for query startup since there's a window where new queries can start running on the backend that is being shut down. It's not related to impalad startup http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.h@119 PS18, Line 119: /// executing). If it is quiesced then it cleanly shut downs by exiting the process. > nit: ...cleanly shuts down... oops http://gerrit.cloudera.org:8080/#/c/10744/17/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10744/17/be/src/service/impala-server.cc@214 PS17, Line 214: // control queue timeout + some margin for error? > line too long (92 > 90) Done http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/10744/18/be/src/service/impala-server.cc@2408 PS18, Line 2408: if (set_grace) { > nit: online? Doesn't quite fit.. http://gerrit.cloudera.org:8080/#/c/10744/17/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10744/17/common/thrift/ImpalaInternalService.thrift@842 PS17, Line 842: 4: optional Types.TFragmentIdx dst_fragment_idx > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/10744/18/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: http://gerrit.cloudera.org:8080/#/c/10744/18/common/thrift/ImpalaInternalService.thrift@857 PS18, Line 857: // Deadline for the shutdown. After this deadline expires (starting at the time when this > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/10744/17/tests/common/impala_cluster.py@210 PS17, Line 210: > flake8: E701 multiple statements on one line (colon) Done http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/10744/18/tests/custom_cluster/test_restart_services.py@101 PS18, Line 101: = > flake8: E225 missing whitespace around operator Done (along with other warnings in this file). -- To view, visit http://gerrit.cloudera.org:8080/10744 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d5606ccfec84db4482c1e7f0f198103aad141a0 Gerrit-Change-Number: 10744 Gerrit-PatchSet: 18 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Pranay Singh Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Mon, 10 Sep 2018 19:26:37 +0000 Gerrit-HasComments: Yes
