Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11469 )
Change subject: IMPALA-7591: Use short name for setting owner ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/11469/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11469/2//COMMIT_MSG@13 PS2, Line 13: getShortName Please add the class name as there are more than one getShortName() functions. http://gerrit.cloudera.org:8080/#/c/11469/2//COMMIT_MSG@15 PS2, Line 15: BadFormatString I would prefer if there was such a test if it is not too hard to create one. http://gerrit.cloudera.org:8080/#/c/11469/2/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java File fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java: http://gerrit.cloudera.org:8080/#/c/11469/2/fe/src/main/java/org/apache/impala/analysis/AlterViewStmt.java@53 PS2, Line 53: try optional: I would add a function like getShortName() to Analyzer/StatementBase/User that does the exception translation to avoid code duplication. -- To view, visit http://gerrit.cloudera.org:8080/11469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab392a0cd5c0bb98442e1f7ac39f470310a21f11 Gerrit-Change-Number: 11469 Gerrit-PatchSet: 2 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Sep 2018 14:40:24 +0000 Gerrit-HasComments: Yes
