Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11469 )
Change subject: IMPALA-7591: Use short name for setting owner ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/11469/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11469/3//COMMIT_MSG@18 PS3, Line 18: - Ran all frontend, and e2e tests. were any manual tests run on a Kerberized cluster? http://gerrit.cloudera.org:8080/#/c/11469/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/11469/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2347 PS3, Line 2347: getShortName() for user this is a user-visible error, so I doubt they care about method calls. the stack trace will be in the log, which will make this clear. for the user, how about: "Could not get the shortened name for user: ..."? http://gerrit.cloudera.org:8080/#/c/11469/3/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@2348 PS3, Line 2348: e the exception that's thrown by User has the same message as the line on L2347, so there's some duplication there. more reason to make the message here more consumable. -- To view, visit http://gerrit.cloudera.org:8080/11469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iab392a0cd5c0bb98442e1f7ac39f470310a21f11 Gerrit-Change-Number: 11469 Gerrit-PatchSet: 3 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Fri, 21 Sep 2018 16:06:47 +0000 Gerrit-HasComments: Yes
