Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11502 )
Change subject: IMPALA-7456: Deprecate file-based authorization ...................................................................... Patch Set 1: (9 comments) http://gerrit.cloudera.org:8080/#/c/11502/1/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/11502/1/tests/authorization/test_authorization.py@378 PS1, Line 378: \ flake8: E502 the backslash is redundant between brackets http://gerrit.cloudera.org:8080/#/c/11502/1/tests/authorization/test_authorization.py@385 PS1, Line 385: flake8: W391 blank line at end of file http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py File tests/common/file_utils.py: http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py@62 PS1, Line 62: def grep_dir(dir, search): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py@78 PS1, Line 78: def grep_file(file, search): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py@88 PS1, Line 88: def assert_file_in_dir_contains(dir, search): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py@90 PS1, Line 90: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py@94 PS1, Line 94: def assert_no_files_in_dir_contain(dir, search): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/11502/1/tests/common/file_utils.py@96 PS1, Line 96: , flake8: E231 missing whitespace after ',' http://gerrit.cloudera.org:8080/#/c/11502/1/tests/custom_cluster/test_redaction.py File tests/custom_cluster/test_redaction.py: http://gerrit.cloudera.org:8080/#/c/11502/1/tests/custom_cluster/test_redaction.py@30 PS1, Line 30: from tests.common.file_utils import grep_dir, grep_file, assert_file_in_dir_contains,\ flake8: F401 'tests.common.file_utils.grep_dir' imported but unused -- To view, visit http://gerrit.cloudera.org:8080/11502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbb13f3ef1c3a00812c180ecef022ea638c2ebc7 Gerrit-Change-Number: 11502 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Sep 2018 13:07:02 +0000 Gerrit-HasComments: Yes
