Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11502 )
Change subject: IMPALA-7456: Deprecate file-based authorization ...................................................................... Patch Set 1: (3 comments) LGTM after couple flake8 errors are fixed. http://gerrit.cloudera.org:8080/#/c/11502/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11502/1//COMMIT_MSG@9 PS1, Line 9: add nit: adds http://gerrit.cloudera.org:8080/#/c/11502/1//COMMIT_MSG@10 PS1, Line 10: Sentry has : depreated the use of policy files Please put a SENTRY JIRA for this. http://gerrit.cloudera.org:8080/#/c/11502/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/11502/1/fe/src/main/java/org/apache/impala/service/JniFrontend.java@700 PS1, Line 700: authorization_policy_file flag is deprecated Instead of mentioning the flag name, maybe it's better to say "Authorization policy file is deprecated. Object Ownership feature is not supported with authorization policy file". -- To view, visit http://gerrit.cloudera.org:8080/11502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibbb13f3ef1c3a00812c180ecef022ea638c2ebc7 Gerrit-Change-Number: 11502 Gerrit-PatchSet: 1 Gerrit-Owner: Adam Holley <ahol...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Sep 2018 13:44:21 +0000 Gerrit-HasComments: Yes
