Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 )
Change subject: IMPALA-2063 Remove newline characters in query status. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11425/5/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/11425/5/be/src/util/runtime-profile.cc@551 PS5, Line 551: // If there is a newline-like character, remove duplicates > That's fine. The only reason the double newline is being stripped is becau I guess a more meaningful test is to verify that all "Query Status" (not just Status: Cancelled) (or in general any info string) don't end with whitespace / newline. I can see either incorporating that verification into some test infrastructure (e.g. somewhere in test_result_verifier.py) or you write a test which triggers different types of query statuses (e.g. OK, mem limit exceeded, scan error, cancelled etc) to verify that they don't end with whitespaces. The former seems to be more future-proof. -- To view, visit http://gerrit.cloudera.org:8080/11425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbd7d7fe2c6d0f3799d0e6b336710bccfef0ab1 Gerrit-Change-Number: 11425 Gerrit-PatchSet: 5 Gerrit-Owner: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Oct 2018 17:56:55 +0000 Gerrit-HasComments: Yes