Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11425 )
Change subject: IMPALA-2063 Remove newline characters in query status. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/11425/5/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/11425/5/be/src/util/runtime-profile.cc@551 PS5, Line 551: // If there is a newline-like character, remove duplicates > The test for double newlines effectively was a test that info strings aren' Actually, it's possible to get the value of individual field with the Thrift profile. So, it's definitely possible to just extract the "Query Status" field from the final profile. Copying some code from test_observability.py: tree = self.impalad_test_service.get_thrift_profile(query_id) if tree: query_status = tree.nodes[1].info_strings["Query Status"] assert query_status == query_status.rstrip() -- To view, visit http://gerrit.cloudera.org:8080/11425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2bbd7d7fe2c6d0f3799d0e6b336710bccfef0ab1 Gerrit-Change-Number: 11425 Gerrit-PatchSet: 5 Gerrit-Owner: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michal Ostrowski <mostr...@cloudera.com> Gerrit-Comment-Date: Tue, 02 Oct 2018 19:30:08 +0000 Gerrit-HasComments: Yes
