Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 )
Change subject: IMPALA-7484: Unrecognized hints are interpreted as straight_join ...................................................................... Patch Set 4: (5 comments) Thanks Vuk, submitted new patch. http://gerrit.cloudera.org:8080/#/c/11568/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11568/3//COMMIT_MSG@7 PS3, Line 7: IMPALA-7484: Unrecognized hints are interpreted as straight_join > add a newline Done http://gerrit.cloudera.org:8080/#/c/11568/3//COMMIT_MSG@8 PS3, Line 8: > wrap this appropriately. Done http://gerrit.cloudera.org:8080/#/c/11568/3//COMMIT_MSG@10 PS3, Line 10: causing even unrecognized hints to be interpreted as straight_joins. > same here, please wrap the lines. Done http://gerrit.cloudera.org:8080/#/c/11568/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/11568/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1845 PS3, Line 1845: // If hint is straight join > add a space after '//' Done http://gerrit.cloudera.org:8080/#/c/11568/3/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1851 PS3, Line 1851: // Unrecognized hint > same here, add a space. Done -- To view, visit http://gerrit.cloudera.org:8080/11568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 Gerrit-Change-Number: 11568 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Oct 2018 07:20:12 +0000 Gerrit-HasComments: Yes
