Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11568 )
Change subject: IMPALA-7484: Do not interpret unrecognized hints as straight_join hints. ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1830 PS5, Line 1830: Anal I was expecting all of these cases to use the wrapper. We'll get more coverage this way. The error addressed here would not have been present if these checks were in place. http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1852 PS5, Line 1852: er to test if straight_join hints pls reword this so its clear that this does not test the hint (just returns a state) http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1855 PS5, Line 1855: check replace "check" with "has" http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1855 PS5, Line 1855: private boolean checkStraightJoin(String stmt, String expectedWarning){ put the helper before its use, e.g., on L1824 http://gerrit.cloudera.org:8080/#/c/11568/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1858 PS5, Line 1858: // Unrecognized hint what's this comment for? -- To view, visit http://gerrit.cloudera.org:8080/11568 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf600ebbfefc7398e0896df143a0ab91545cae04 Gerrit-Change-Number: 11568 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Oct 2018 23:06:31 +0000 Gerrit-HasComments: Yes
