Thomas Marshall has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/11625 )

Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for 
debug webserver"
......................................................................


Patch Set 3:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_client_ssl.py
File tests/custom_cluster/test_client_ssl.py:

http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_client_ssl.py@116
PS2, Line 116:
> flake8: E261 at least two spaces before inline comment
Done


http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py
File tests/custom_cluster/test_redaction.py:

http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@149
PS2, Line 149:
> flake8: E501 line too long (127 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@160
PS2, Line 160:
> flake8: E501 line too long (111 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/11625/2/tests/custom_cluster/test_redaction.py@167
PS2, Line 167:
> flake8: E501 line too long (114 > 90 characters)
Done


http://gerrit.cloudera.org:8080/#/c/11625/2/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/11625/2/tests/run-tests.py@220
PS2, Line 220: s
> flake8: E126 continuation line over-indented for hanging indent
Done



--
To view, visit http://gerrit.cloudera.org:8080/11625
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544
Gerrit-Change-Number: 11625
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu>
Gerrit-Comment-Date: Thu, 11 Oct 2018 16:45:02 +0000
Gerrit-HasComments: Yes

Reply via email to