Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11625 )
Change subject: IMPALA-7678: Reapply "IMPALA-7660: Support ECDH ciphers for debug webserver" ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Update the commit message, otherwise looks good. http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11625/3//COMMIT_MSG@15 PS3, Line 15: urllib.urlopen has been deprecated since 2.6 anyways, so the fix is to : switch to using the more current urllib2. Now that you are using the "requests" library, update this commit message. -- To view, visit http://gerrit.cloudera.org:8080/11625 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I679469ed7f27944f75004ec4b16d513e6ea6b544 Gerrit-Change-Number: 11625 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Pooja Nilangekar <pooja.nilange...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Fri, 12 Oct 2018 21:14:21 +0000 Gerrit-HasComments: Yes
