Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11696 )
Change subject: IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/11696/2/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/11696/2/tests/authorization/test_authorization.py@397 PS2, Line 397: self.role_cleanup(unique_role) > We use "unique database" in some places. Roles are global, so we should may Using unique_database will create a database which we don't need. Furthermore, it also requires a special CREATE privilege which needs to be set up, but is unnecessary for this particular test. I decided to create a new fixture called unique_role instead, which returns a unique role name. http://gerrit.cloudera.org:8080/#/c/11696/2/tests/authorization/test_authorization.py@413 PS2, Line 413: "all", "false"]) : : result = self.client.execute("show grant role %s_bar" % unique_role) : assert len(result.data) == 1 : TestAuthorization._check_privileges(result.data[0].split("\t"), : ["database", "functional_kudu", "", "", "", : "all", "false"]) : : result = self.client.execute("show grant role %s_baz" % unique_role) : assert len(result.data) == 1 : TestAuthorization._check_privileges(result.data[0].split("\t"), : ["database", "functional_avro", "", "", "", : "all", "false"]) : : self._start_impala_cluster(["--catalogd_args=--sentry_config=%s" % : SENTRY_CONFIG_FILE, "--restart_catalogd_only"]) : > Can you run this both before and after the restart? Done -- To view, visit http://gerrit.cloudera.org:8080/11696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a168697401cf0b83c7a193fa477888b48cb369 Gerrit-Change-Number: 11696 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Oct 2018 20:25:45 +0000 Gerrit-HasComments: Yes
