Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11696 )
Change subject: IMPALA-7713: Add test coverage for catalogd restart when authorization is enabled ...................................................................... Patch Set 5: Code-Review+2 (2 comments) Carry Phil's +2. http://gerrit.cloudera.org:8080/#/c/11696/4/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/11696/4/tests/authorization/test_authorization.py@399 PS4, Line 399: TestAuthorization._check_privileges(result, [["database", "functional", : "", "", "", "all", "false"]]) : : result = self.client.execute("show grant role %s_bar" > If you really wanted to, you could make 399 part of _check_privileges(). An I like the conciseness. Done. http://gerrit.cloudera.org:8080/#/c/11696/4/tests/authorization/test_authorization.py@443 PS4, Line 443: > Where is create_time here? I don't quite see what this is skipping. I forgot to remove this. It's no longer needed. Done. -- To view, visit http://gerrit.cloudera.org:8080/11696 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9a168697401cf0b83c7a193fa477888b48cb369 Gerrit-Change-Number: 11696 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Comment-Date: Wed, 17 Oct 2018 01:34:59 +0000 Gerrit-HasComments: Yes
