Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 )
Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. ...................................................................... Patch Set 2: > > It seems good to me, but I would ping Greg Rahn in the Jira, > maybe > > he has some ideas. > > I have pinged him > > > I have one issue with the current output: as I saw in the .test > > files, queries are printed in one line by default, which can make > > complex queries very difficult to read. It would be much nicer to > > break them at logical points, but I have no idea how to do it > > easily. > > I agree that a clever printing would be nice, but that sounds > tricky. I could wrap at say the last space before 80 columns with > only small effort, but this will make the header harder to parse in > tests. Should I try this? About good places to start new line: the enum could have a property whether to add new lines, and some ParseNodes could add new lines if it is true, e.g before joins and unions. Another idea (of the "if you already touch it, why not rewrite the whole thing" type, so it is optional): if there is an object passed to toSql(), maybe it could be some kind of ToSqlBuilder instead of ToSqlOption. It could contain the implicit cast related information and could be also used as a string builder. The current implementation uses string builders in most nodes, but I think that toSql() can still be O(n^2) in some cases. -- To view, visit http://gerrit.cloudera.org:8080/11719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55c3bdacc295137f66b2316a912fc347da30d6b0 Gerrit-Change-Number: 11719 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Fri, 19 Oct 2018 20:22:41 +0000 Gerrit-HasComments: No
