Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 )
Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. ...................................................................... Patch Set 2: (3 comments) > > It seems good to me, but I would ping Greg Rahn in the Jira, > maybe > > he has some ideas. > > I have pinged him > > > I have one issue with the current output: as I saw in the .test > > files, queries are printed in one line by default, which can make > > complex queries very difficult to read. It would be much nicer to > > break them at logical points, but I have no idea how to do it > > easily. > > I agree that a clever printing would be nice, but that sounds > tricky. I could wrap at say the last space before 80 columns with > only small effort, but this will make the header harder to parse in > tests. Should I try this? Doing the simple thing (wrapping at 80) is probably fine. http://gerrit.cloudera.org:8080/#/c/11719/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11719/2//COMMIT_MSG@32 PS2, Line 32: If a query in a .test file produces a diff when run by PlannerTest, : then print the name of the .test file in the output. Could you submit this as a standalone review? If I understand correctly, it doesn't really have anything to do with the rest of the review, and its nice to keep changes relatively focused, esp. since this is already such a large patch. http://gerrit.cloudera.org:8080/#/c/11719/2//COMMIT_MSG@67 PS2, Line 67: Is "Query with implicit casts:" a good description? Any reason not to also show the rewritten sql here and call this something like "Analyzed query" http://gerrit.cloudera.org:8080/#/c/11719/2/testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test File testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test: http://gerrit.cloudera.org:8080/#/c/11719/2/testdata/workloads/functional-planner/queries/PlannerTest/constant-folding.test@59 PS2, Line 59: c_custkey > 10 not sure how difficult this would be, but it would be nice to include the implicit casts here too -- To view, visit http://gerrit.cloudera.org:8080/11719 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I55c3bdacc295137f66b2316a912fc347da30d6b0 Gerrit-Change-Number: 11719 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Fri, 19 Oct 2018 22:58:18 +0000 Gerrit-HasComments: Yes
