Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 )
Change subject: IMPALA-7714: remove unsafe code from signal handlers ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Just a nit http://gerrit.cloudera.org:8080/#/c/11777/2/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/11777/2/be/src/common/init.cc@189 PS2, Line 189: // Signal handler for SIGTERM, that prints the message before doing an exit. Should we add a comment why we call _exit() instead of exit()? -- To view, visit http://gerrit.cloudera.org:8080/11777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52037d6510b9b34ec33d3a8b5492226aee1b9d92 Gerrit-Change-Number: 11777 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 25 Oct 2018 16:39:00 +0000 Gerrit-HasComments: Yes
