Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/11777 )
Change subject: IMPALA-7714: remove unsafe code from signal handlers ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/11777/5/be/src/common/init.cc File be/src/common/init.cc: http://gerrit.cloudera.org:8080/#/c/11777/5/be/src/common/init.cc@192 PS5, Line 192: sys_write(STDOUT_FILENO, msg, strlen(msg)); One question: Does this mean that we can't log the shutdown message to Impala log file? Or does STDOUT_FILENO get duped to impalad.INFO? http://gerrit.cloudera.org:8080/#/c/11777/5/be/src/util/minidump.cc File be/src/util/minidump.cc: http://gerrit.cloudera.org:8080/#/c/11777/5/be/src/util/minidump.cc@102 PS5, Line 102: sys_write(STDOUT_FILENO, msg, strlen(msg)); Same question as in the other .cc file. -- To view, visit http://gerrit.cloudera.org:8080/11777 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52037d6510b9b34ec33d3a8b5492226aee1b9d92 Gerrit-Change-Number: 11777 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Oct 2018 17:10:18 +0000 Gerrit-HasComments: Yes
