Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11864 )
Change subject: IMPALA-7775: fix some lifecycle issues in statestore/session tests ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/11864/2/be/src/service/session-expiry-test.cc File be/src/service/session-expiry-test.cc: http://gerrit.cloudera.org:8080/#/c/11864/2/be/src/service/session-expiry-test.cc@53 PS2, Line 53: scoped_ptr<MetricGroup> metrics(new MetricGroup("statestore")); Does this need to live in an ObjectPool too like what was done in statestore-test.cc ? http://gerrit.cloudera.org:8080/#/c/11864/2/be/src/statestore/statestore-test.cc File be/src/statestore/statestore-test.cc: http://gerrit.cloudera.org:8080/#/c/11864/2/be/src/statestore/statestore-test.cc@40 PS2, Line 40: static ObjectPool* perm_objects Why not just static ObjectPool perm_object; ? Does it have anything to do with the IMPALA-5291 comment in main() ? -- To view, visit http://gerrit.cloudera.org:8080/11864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b25c8b8a96bfa1183ce273b3bb4debde234dd01 Gerrit-Change-Number: 11864 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Fri, 02 Nov 2018 22:54:28 +0000 Gerrit-HasComments: Yes
